rancher / rancher

Complete container management platform
http://rancher.com
Apache License 2.0
23.5k stars 2.98k forks source link

[BUG] Add node metrics permissions to nodes view role #45849

Open GaboFDC opened 5 months ago

GaboFDC commented 5 months ago

Rancher Server Setup

Information about the Cluster

alexandreLamarre commented 5 months ago

rancher-monitoring has separate RBAC roles : https://ranchermanager.docs.rancher.com/integrations-in-rancher/monitoring-and-alerting/rbac-for-monitoring, while seemingly a small change integrating with the more global rancher roles presents some non-trivial rbac challenges

GaboFDC commented 3 months ago

I'm not sure if those metrics are provided by rancher-monitoring. You get those metrics by default even if it is not installed. See the PR, and also in https://github.com/rancher/rancher/issues/36116 / https://github.com/rancher/rancher/pull/36493 it was already added to cluster members

GaboFDC commented 1 week ago

Hello, any comments on this? The PR got auto-closed as there was no activity. I'm waiting on further feedback, as explained, this seems to be a valid change.