search

rancher / renovate-config

3 stars 5 forks source link

Renovate creates empty go mod bump prs #271

Open thardeck opened 2 months ago

thardeck commented 2 months ago

Renovate creates empty go mod bump prs. It basically is a bump but when we run go mod tidy, the changes are removed, so they are effectively empty.

We have a CI which checks for automatic generated changes, which among others run go mod tidy, that's why our CI was failing.

These are the two prs I saw with this issue: https://github.com/rancher/fleet/pull/2303 https://github.com/rancher/fleet/pull/2306

Maybe renovate bumps an indirect dependency but the other components still require the old version, that's why the new component is not used and removed by go mod tidy again.

thardeck commented 3 weeks ago

@pjbgf another example of empty mod bumps: https://github.com/rancher/fleet/pull/2501

If I run go mod tidy on it the changes are reversed, that's why our own CI verifcation (Verify generated code changes / check-changes) is failing.