search

rancher / rio

Application Deployment Engine for Kubernetes
https://rio.io
Apache License 2.0
2.27k stars 228 forks source link

Rio does not redeploy after a secret changes #1027

Open frafra opened 4 years ago

frafra commented 4 years ago

Describe the bug Changing a secret has no effect if no other actions are taken

To Reproduce

  1. Add a secret
  2. rio up
  3. Change the secret

Expected behavior It would make sense to update the deployment when the secret changes

Kubernetes version & type (GKE, on-prem): kubectl version

Client Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.8-beta.0", GitCommit:"6c143d35bb11d74970e7bc0b6c45b6bfdffc0bd4", GitTreeState:"archive", BuildDate:"2020-01-02T00:00:00Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.3-k3s.2", GitCommit:"e7e6a3c4e9a7d80b87793612730d10a863a25980", GitTreeState:"clean", BuildDate:"2019-11-18T18:31:23Z", GoVersion:"go1.13.4", Compiler:"gc", Platform:"linux/amd64"}

Type: Rio version: rio info

Rio Version: v0.7.0 (4afd4901)
Rio CLI Version: v0.7.0 (4afd4901)
Cluster Domain: qf1wd5.on-rio.io
Cluster Domain IPs: 185.136.233.169
System Namespace: rio-system
Wildcard certificates: qf1wd5.on-rio.io(true)
StrongMonkey commented 4 years ago

When you change the secret, the secret mounted inside the deployment should automatically get changed. There is nothing needs to be done on the rio side, it is automatically updated by kubelet. Are you referring to a different use case?