search

rancher / rio

Application Deployment Engine for Kubernetes
https://rio.io
Apache License 2.0
2.27k stars 228 forks source link

dont allow empty service generation #944

Closed cbron closed 4 years ago

cbron commented 4 years ago

Issue: #542

cbron commented 4 years ago

@StrongMonkey the gitcommit/service change isn't perfect because it still re-creates the pr2 service when pr1 closes, those two should be unrelated events, but at least now it reloads to the right commit.

StrongMonkey commented 4 years ago

I think it should be fine, if it loads the right commit then it shouldn't recreate pr2 if pr2 already exists.