rancher / rio

Application Deployment Engine for Kubernetes
https://rio.io
Apache License 2.0
2.27k stars 228 forks source link

no option to specify secret name #954

Open oskapt opened 4 years ago

oskapt commented 4 years ago

Note: Please add dashboard specific bugs to the dashboard repo: https://github.com/rancher/dashboard/issues

Describe the bug A clear and concise description of what the bug is.

The rio commands create a secret of a predefined name and assume that running a workload will always use the same secret. See this page where it states:

Rio will automatically use this secret now when doing standard git checkout, so no additional flags need to be passed.

While I can specify which secret to use when using rio run, there is no non-manual way to create a secret with a different name.

A side-effect of this is also that rio secret clobbers the same secret when run multiple times.

Expected Behavior

I would like to be able to create multiple secrets for different private repos (gitlab/github/personal), update them, and specify which secret to use when building/deploying applications within Rio. This could be solved by permitting me to name the secret when creating/updating it.

I also think that Rio shouldn't assume which secret I want to use. If I'm using a per-repo deploy token or deploy key, does it know to use the key for gitlab.com/monachus/private-project and not to use it with gitlab.com/monachus/other-project where other-project might need a different key?

If no key is provided in the command, it should not use a key and should fail because it did not have permission to access the repo. If a key is provided in the command, it should use the key. This is more in line with the command-line instructions provided by the user.