Don't create webhook without build-webhook-secret specified

rancher / rio

Application Deployment Engine for Kubernetes

https://rio.io

Apache License 2.0

2.27k stars 228 forks source link

Closed cbron closed 4 years ago

cbron commented 4 years ago

Currently gitwatcher picks up a secret named 'githubtoken' if it exists by default. We should disable this behavior as it is confusing for the users.

Testing:

make sure hook is not created when default secret exists but not passed in rio-run cmd
make sure passing in the secret param during rio run still allows PR mode and new commits to work

rancher-max commented 4 years ago

working in master