search

rancher / rio

Application Deployment Engine for Kubernetes
https://rio.io
Apache License 2.0
2.27k stars 228 forks source link

Notify user if unable to create webhook #971

Open oskapt opened 4 years ago

oskapt commented 4 years ago 
rio run -p 80/http -n rio-test \
  --build-clone-secret=gitcredential-ssh \
  --build-webhook-secret=gitcredential-ssh \
  git@github.com:oskapt/rio-test

This obviously won't work because I'm trying to use the SSH token to create the webhook. It creates the service, but it doesn't generate an error about the webhook. This causes the user to believe that the webhook might have been created.

cbron commented 4 years ago

This gives me a generic git error when running rio ps (perhaps unrelated). You do get a failed webhook error when template is on, but there is a bug where if template is off you don't. So in general we need more consistent messaging around webhook errors.