search

rancher / rio

Application Deployment Engine for Kubernetes
https://rio.io
Apache License 2.0
2.27k stars 228 forks source link

Create webhook when deploying via SSH and given a token #972

Open oskapt opened 4 years ago

oskapt commented 4 years ago

If a service is started with an SSH key, but a token was provided for creating a webhook, we should be able to infer the repo name and create the webhook, right? This doesn't appear to be happening, yet no error is reported (#971).

cbron commented 4 years ago

Assuming you mean that this fails with valid creds:rio run -p 80/http -n rio-test --build-clone-secret=gitcredential-ssh --build-webhook-secret=githubtoken git@github.com:user/repo because repo url is not in standard format. I confirmed that. If you check the gitwatcher it does show an error but we don't bubble that up to the service. We already have a ticket for that so this ticket can stay for handling the ssh style url git@github.com:user/repo ->github.com/user/repo

oskapt commented 4 years ago

Yes, correct as you described it. If you already have an issue for this that will be resolved soon, you can close this. If it won't be resolved soon, please consider this a request to notify the user that the requested action failed.