rancher / rio

Application Deployment Engine for Kubernetes
https://rio.io
Apache License 2.0
2.27k stars 228 forks source link

Allow custom cluster domains to support https when letsencrypt feature is disabled #990

Open rancher-max opened 4 years ago

rancher-max commented 4 years ago

It appears that ClusterDomain is only set to HTTPS inside LetsEncrypt controller (see https://github.com/rancher/rio/blob/master/modules/letsencrypt/controllers/clusterdomain/controller.go). We need to push logic into its own controller.

This will allow user to disable letsencrypt and rdns and still provide https endpoints.

Steps here: https://github.com/rancher/rio/issues/700#issuecomment-572414602 Current Workaround: Do not disable letsencrypt when installing rio. Potentially can delete cert-manager workload and disable letsencrypt after applying own clusterdomain.