search

rancher / rke

Rancher Kubernetes Engine (RKE), an extremely simple, lightning fast Kubernetes distribution that runs entirely within containers.
Apache License 2.0
3.22k stars 584 forks source link

Choose one source for pulling CNI plugins #3327

Open manuelbuil opened 1 year ago

manuelbuil commented 1 year ago

CNI plugin binaries are being pulled in three different places:

1 - In hyperkube-base: https://github.com/rancher/hyperkube-base/blob/master/Makefile#L30-L32 2 - In rke-tools: https://github.com/rancher/rke-tools/blob/master/package/Dockerfile#L25-L27 3 - CNI plugins include logic to distribute CNI plugin binaries too (not clear about Weave though)

We should investigate why but I suspect it is just a mistake. In that case, we should decide on one (probably 3), verify that things work and remove the rest

github-actions[bot] commented 1 year ago

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.