search

rancher / rke2-docs

Apache License 2.0
8 stars 77 forks source link

Mention CRD install for system-upgrade-controller #228

Closed dereknola closed 2 months ago

dereknola commented 4 months ago

Addresses: https://github.com/rancher/rke2-docs/issues/222

Signed-off-by: Derek Nola derek.nola@suse.com

manuelbuil commented 4 months ago

There is one caveat if we follow these steps, there are two resources (role and rolebinding) that fail to be created because the namespace was not yet created. The namespace gets created in system-upgrade-controller.yaml too but I guess it is not there yet when needed

 Error from server (NotFound): error when creating "https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml": namespaces "system-upgrade" not found
Error from server (NotFound): error when creating "https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml": namespaces "system-upgrade" not found

If I apply system-upgrade-controller.yaml again, it works. Maybe we should warn users about it?

brandond commented 4 months ago

I have been meaning to get a bit more hands-on with that repo; I allowed some folks to make changes to the deployment manifests that in retrospect only work well when using kustomize, and have made things a bit more painful if just using kubectl apply as we suggest in other repos docs.

manuelbuil commented 4 months ago

I have been meaning to get a bit more hands-on with that repo; I allowed some folks to make changes to the deployment manifests that in retrospect only work well when using kustomize, and have made things a bit more painful if just using kubectl apply as we suggest in other repos docs.

Agree, I think the user experience became worse. 0.13.2 was simple to install

dereknola commented 2 months ago

Regardless of making SUC better, this does fix the upgrade docs to at least work.