search

rancher / rke2

https://docs.rke2.io/
Apache License 2.0
1.48k stars 260 forks source link

--etcd-snapshot-name help is garbled #5303

Open dereknola opened 7 months ago

dereknola commented 7 months ago

Describe the bug:

running rke2 server -h produces the following:

   --etcd-snapshot-name value                    (db) Set the base name of etcd snapshots (default: etcd-snapshot-<unix-timestamp>) (default: "etcd-snapshot")

we need to cleanup the defaults and print the correct one.

Steps To Reproduce:

Expected behavior:

Actual behavior:

Additional context / logs:

dereknola commented 6 months ago

This is related to urfave v1 CLI, and is a limitation of that old version. If we move to urfave v2, we can fix this. I have started the process with opening a PR to migrate containerd into the new version. If that is accepted, we can migrate RKE2 and K3s as well.

dereknola commented 2 months ago

The PR was merged and accepted for containerd 2.0, which will likely come out sometime 2024.