rancher / rke2

https://docs.rke2.io/
Apache License 2.0
1.53k stars 266 forks source link

Fix e2e test bug in mixedosbgp #6840

Closed manuelbuil closed 1 week ago

manuelbuil commented 1 week ago

Proposed Changes

This PR fixes a bug in the mixedosbgp e2e test. -Commit= is wrong, the equal symbol should be removed. We were getting an error when installing rke2 in windows.

Types of Changes

Bugfix

Verification

Run the e2e test

Testing

Linked Issues

User-Facing Change

Further Comments

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 9.54%. Comparing base (b8dfafa) to head (fb38f55).

:exclamation: There is a different number of reports uploaded between BASE (b8dfafa) and HEAD (fb38f55). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (b8dfafa) | HEAD (fb38f55) | |------|------|------| |unittests|1|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6840 +/- ## ========================================== - Coverage 25.11% 9.54% -15.57% ========================================== Files 33 33 Lines 2839 2839 ========================================== - Hits 713 271 -442 - Misses 2079 2545 +466 + Partials 47 23 -24 ``` | [Flag](https://app.codecov.io/gh/rancher/rke2/pull/6840/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rancher) | Coverage Δ | | |---|---|---| | [inttests](https://app.codecov.io/gh/rancher/rke2/pull/6840/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rancher) | `9.54% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/rancher/rke2/pull/6840/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rancher) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rancher#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.