search

rancher / system-upgrade-controller

In your Kubernetes, upgrading your nodes
Apache License 2.0
742 stars 85 forks source link

PodSelector and ignore-errors as a parameter to the drain command #218

Open rajivml opened 1 year ago

rajivml commented 1 year ago

HI,

We have started exploring system-upgrade-controller for our upgrades but for us to onboard we want podselector and ignore-errors as additional parameters that can be passed to drain command

Today in our production this is how we drain the node as per longhorn's recommendation,

kubectl drain "$HOST_NAME_NODE" --delete-emptydir-data --ignore-daemonsets --force --disable-eviction=true --timeout=30s --ignore-errors --skip-wait-for-delete-timeout=10 --pod-selector 'app!=csi-attacher,longhorn.io/component!=instance-manager,k8s-app!=kube-dns'

Can we have this added, please

rajivml commented 1 year ago

looks like there is already an open ticket and PR for this, can we get this PR merged https://github.com/rancher/system-upgrade-controller/issues/207 https://github.com/rancher/system-upgrade-controller/pull/215/files

jstewart612 commented 1 year ago

This was added in a commit two weeks ago or so: https://github.com/rancher/system-upgrade-controller/pull/231 which looks like it will go out in the 0.11.0 release.

You can try the dev1 prerelease if you're feeling lucky :)