search

rancher / system-upgrade-controller

In your Kubernetes, upgrading your nodes
Apache License 2.0
723 stars 86 forks source link

Allow Plan to specify Job deadline #244

Closed connorkuehl closed 1 year ago

connorkuehl commented 1 year ago

If a workload is known to be slow in excess of the system-upgrade-controller deployment's default deadline, allow the Plan creator to specify a job deadline with the plan so that the entailing job may run to completion.

connorkuehl commented 1 year ago

@brandond Would you be willing to take a look at this?

connorkuehl commented 1 year ago

Thanks for the review! :slightly_smiling_face:

connorkuehl commented 1 year ago

I'm still learning about the Rancher ecosystem, so at the risk of asking a dumb question: is there a way for me to track when this change is packaged up as part of a Rancher release?

brandond commented 1 year ago

If there's not an issue to upgrade the version of the SUC used by Rancher's upgrade charts, one will need to be created to track doing so. Standalone users can use the new release whenever they want, of course.