search

rancher / system-upgrade-controller

In your Kubernetes, upgrading your nodes
Apache License 2.0
723 stars 86 forks source link

`crd.yaml` is not attached to Github release for v0.12.0 #247

Closed onedr0p closed 1 year ago

onedr0p commented 1 year ago

Previous releases of SUC there has been a crd.yaml artifact attached to the Github release, it appears missing for v0.12.0.

IT-Cru commented 1 year ago

Also other assets are missing if you compare release v0.12.0 and previous one v0.11.0.

Normally they are 21 assets in last previous releases and in v0.12.0 only 7 exists. Also system-upgrade-controller.yaml is missing and all users which requests

https://github.com/rancher/system-upgrade-controller/releases/latest/download/system-upgrade-controller.yaml

get a HTTP status 404 currently. So all usages in any CI jobs or automated processes could be broken.

hurzelpurzel commented 1 year ago

I ended up at the same problem when using the k3s website link to the manifest. Therefore I switched to v11

onedr0p commented 1 year ago

Sorry to be a bit of a bother but it kind of sucks how painful this project is to deploy... no Helm chart, barely functional kustomize support, no way to install CRDs separately outside using the Github release artifact (which is currently broken).

It would be nice to have a standard/cleaner automated way to install and manage updates to this outside of kubectl apply -f https://... but it doesn't look like it will get the love it needs to make that happen.

I don't mean to come off rude or anything, just hopefully giving some constructive criticism that may help make things better.

hurzelpurzel commented 1 year ago

Checked the scripts subfolder. All the build stuff is located there. I found that the AMD64 build hasn't been run for v.12.0 and that is reason for the missing CRD.

hurzelpurzel commented 1 year ago

Sorry to be a bit of a bother but it kind of sucks how painful this project is to deploy... no Helm chart, barely functional kustomize support, no way to install CRDs separately outside using the Github release artifact (which is currently broken).

It would be nice to have a standard/cleaner automated way to install and manage updates to this outside of kubectl apply -f https://... but it doesn't look like it will get the love it needs to make that happen.

I don't mean to come off rude or anything, just hopefully giving some constructive criticism that may help make things better.

Added a helm chart in PR #248

onedr0p commented 1 year ago

@brandond any thoughts here?

brandond commented 1 year ago

Tag CI failed, for reasons that do not appear to be related to anything that was changed in this release. I'll re-run it and see if it completes successfully.

brandond commented 1 year ago

It looks like something changed in the CI environment, we'll have to fix that and cut a new tag.

onedr0p commented 1 year ago

Any update here?

onedr0p commented 1 year ago

Looks like this was fixed. Thanks!