search

rancher / system-upgrade-controller

In your Kubernetes, upgrading your nodes
Apache License 2.0
676 stars 83 forks source link

feat: allow plan to ignore secret updates #263

Closed buroa closed 9 months ago

buroa commented 9 months ago

add spec.secret[].ignoreUpdates to allow the definition of a secret and not trigger an update when that secret is altered

closes https://github.com/rancher/system-upgrade-controller/issues/245

duplicate of rancher/system-upgrade-controller#246 but with the e2e test

buroa commented 9 months ago

@dweomer @brandond one for you :)

buroa commented 9 months ago

I tried force pushing the branch to get the build to pass, but looks like ya'll are having some issues internally. Feel free to rerun the build before merging.

brandond commented 9 months ago

Yeah I've restarted it a couple times, I'll try again later.

buroa commented 9 months ago

Got it to build :)

buroa commented 9 months ago

@brandond Thanks for the merge! When should we expect a release cut with this feature?

brandond commented 9 months ago

Not sure. There are a couple other PRs that I would like to see merged or closed before we do another release.

buroa commented 9 months ago

Not sure. There are a couple other PRs that I would like to see merged or closed before we do another release.

Sounds good, no rush! Let me know if I can help in any way :)

keatontaylor commented 8 months ago

Would love to see this in a release, been nearly a month, could we get a release cut @brandond?

buroa commented 7 months ago

@brandond @dweomer @briandowns Can we get a release cut? It's been quite some time now and I really need this feature.