search

rancher / system-upgrade-controller

In your Kubernetes, upgrading your nodes
Apache License 2.0
723 stars 86 forks source link

Add a Complete condition to plans #292

Closed sfackler closed 7 months ago

sfackler commented 7 months ago

It doesn't feel great to be updating the condition in the generating handler instead of the status handler, but this ensures the condition is in sync with the actual state of the plan.

I poked around a bit in the ETE test infrastructure but wasn't totally sure how to add a test for this.

Closes rancher/system-upgrade-controller#291

sfackler commented 7 months ago

Tests are going to flake here due to the s390x removal until #286 lands and I rebase on top of it.

brandond commented 7 months ago

Best way to test would probably be to just find one of the existing tests that waits for the job to complete, and check that the status condition is true when it is done. And check the opposite for a job that is failed.

brandond commented 7 months ago

I just merged that other PR, you should be able to rebase.

sfackler commented 7 months ago

Ah good call - updated one of the job generation tests.

sfackler commented 7 months ago

Thanks! Any idea when the next release'll be cut?

brandond commented 7 months ago

Just did.