search

rancher / system-upgrade-controller

In your Kubernetes, upgrading your nodes
Apache License 2.0
676 stars 83 forks source link

fix: Drop unneeded reorder surpression #296

Closed SISheogorath closed 4 months ago

SISheogorath commented 4 months ago

This patch drops the deprecated flag for output reordering. This causes the output to be ordered properly instead of following the order of the resource list.

References: https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/sortoptions/#legacy-sorting

brandond commented 4 months ago

lgtm, but I'm curious what the problem is with the current ordering?

SISheogorath commented 4 months ago

I don't think there is a problem, it's just not the default. This results in the clusterrole, role and clusterrolebinding being created first before the namespace. I think the apiserver figures that out for us already, but with default reordering the Namespace moves to the top and becomes the first object being created.

rpo-fr commented 1 month ago

look at this: https://github.com/rancher/system-upgrade-controller/releases/#:~:text=%3A%20v0.13.3...v0.13.4-,Important%20Upgrade%20Notice,-If%20upgrading%20to