rancher / system-upgrade-controller

In your Kubernetes, upgrading your nodes
Apache License 2.0
676 stars 83 forks source link

fix imagePullPolicy #306

Open simonfelding opened 3 months ago

simonfelding commented 3 months ago

If imagePullPolicy is set to IfNotPresent and the tag is :latest, you get very unintuitive behavior where Kubernetes will not actually get new versions. This kind of behavior is exactly why it's bad practice to use that tag.

Source: https://kubernetes.io/docs/concepts/containers/images/#updating-images

SISheogorath commented 2 months ago

It would probably be better to drop the explicit definition of the image pull policy and let the Kubernetes mutation webhook do its magic for the image tags.