search

rancher / tasks

1 stars 1 forks source link

[Logging v2] Refactor chart to use template(s) for Logging CRs #191

Open nickgerace opened 3 years ago

nickgerace commented 3 years ago

Task

@aiyengar2 suggested that Logging v2 should follow the pattern utilized by _pod.tpl for Grafana. This would reduce code reuse and decrease chances of human error when adding new charts fields.

Context

Logging v2 had not previously used a CR-specific template file before because the Logging CRs previously existed to only satisfy differing environmental constraints. Moreover, these CR files only contained a fraction of the code reuse seen today. Since Logging v2 has expanded greatly since Rancher v2.5.0, this task should help guide the minimization of code reuse in CR files.

nickgerace commented 3 years ago

Relevant comment: https://github.com/rancher/charts/pull/1182#discussion_r631220748