search

rancher / terraform-aws-rke2

Terraform module to manage an RKE2 node from AWS
GNU General Public License v3.0
1 stars 4 forks source link

terraform plan error #131

Closed ddias00 closed 6 months ago

ddias00 commented 7 months ago

Anotação 2024-02-07 152935

matttrach commented 7 months ago

Ahh, sorry. This was introduced in v1.5 of Terraform, what version of Terraform do you use?

matttrach commented 7 months ago

https://developer.hashicorp.com/terraform/language/v1.5.x/functions/strcontains

I don't use any version after v1.5 for license reasons, but I test on v1.5.7. You can see in the flake.nix where I have the Terraform version set for my environment. The CI uses the same version.

I can probably make this work for an earlier version if necessary though, please let me know which version is best for you.

matttrach commented 7 months ago

https://github.com/rancher/terraform-aws-rke2/blob/main/flake.nix#L114C13-L114C62

ddias00 commented 7 months ago

image image

matttrach commented 7 months ago

ok, I will move testing to v1.4.6, update the required version there and make sure you can get everything working.

So sorry for this! I know that the requirements show v1.2.0, this is just outdated. I should be testing on the minimum required version instead of the maximum. This was totally my fault, I will have an update later today to resolve.

ddias00 commented 7 months ago

No problem my friend, I'll test version 1.5.0 in parallel

ddias00 commented 7 months ago

I got it with version 1.5.7, so probably version 1.4.x doesn't work

matttrach commented 7 months ago

If you are good with v1.5.7, I will set the minimum version to 1.5 so no one else has issues, that will be a much easier change than downgrading the config and all tests. I don't want to disrupt anyone's workflow, so let me know if this is no good for you.

ddias00 commented 7 months ago

no problem for me image

matttrach commented 7 months ago

Nice! Thank you! I will have this change out in the next few hours.

matttrach commented 6 months ago

This should now be resolved. Sorry for the wait, but as a bonus, servers will now have EIP provisioned by default so your public IPs won't change when the server is recreated.