search

rancher / terraform-controller

Use K8s to Run Terraform
Apache License 2.0
292 stars 46 forks source link

Figure out namespacing #17

Open cloudnautique opened 5 years ago

cloudnautique commented 5 years ago

The namespacing of the operator is slightly off. It only watches the namespace it is deployed into. Additionally the k8s clients ignore the namespace parameter when listing the Custom Resources.

luthermonson commented 5 years ago

@cloudnautique this should be closed now, the wrangler port will fix all your concerns with name spacing. We can go over to confirm but here is that PR: https://github.com/rancher/terraform-controller/pull/24

docteurklein commented 4 years ago

Based on what I experience with d28d2f2bb8caa67877e6efe1bd2d22094e810a17, I still think the controller only observes only 1 namespace if you don't pass --namespace. it will default to default:

run with terraform-controller --debug

time="2020-02-04T08:59:46Z" level=info msg="Booting Terraform Controller, namespace: default" func=main.run file="/go/src/github.com/rancher/terraform-controller/main.go:88"

Seems like I don't see the behavior described in the readme: https://github.com/rancher/terraform-controller#namespace.

Am I missing something ?

k0da commented 3 years ago

@docteurklein https://github.com/rancher/terraform-controller/pull/76 should fix this