rancher / terraform-provider-rancher2

Terraform Rancher2 provider
https://www.terraform.io/docs/providers/rancher2/
Mozilla Public License 2.0
260 stars 223 forks source link

[BUG] rancher2_app_v2 values parameter shouldn't be marked as sensitive by the provider #1210

Open lots0logs opened 1 year ago

lots0logs commented 1 year ago

Describe the bug

In response to #499, the values param for rancher2_app_v2 was set to be marked as sensitive by the provider. Now, its impossible to see which values have changed in terraform plan output. There is no way to override it to not be sensitive from outside the provider either.

Not really sure how best this could be addressed. Obviously cannot simply stop marking it as sensitive as that would be a problem for some users. Maybe add some way to tell the provider if you don't want it to be sensitive or add a separate values param that is not sensitive and merge the two before passing to rancher API. :thinking: .

To Reproduce

  1. Deploy a rancher2_app_v2 resource that includes some data in the values param.
  2. Make a change to the data in the values param.
  3. Run terraform plan.
  4. You cant see what changed.

Actual Result

Cannot see what changed for in values param.

Expected Result

Ability to see what changed in values param.

Screenshots

image