Closed khrisrichardson closed 3 weeks ago
CC: @a-blender, could you recommend a reviewer for this PR please? My apologies for keeping it in draft for so long.
CC: @snasovich, would you by any chance be able to assign a reviewer? Thanks
Is it ok to specify both extra_args and the new extra_args_array?
@richardcase that is correct, just as they are not mutually exclusive in the rancher/rancher or rancher/rke code
@richardcase do you have any additional concerns or questions?
Issue:
https://github.com/rancher/terraform-provider-rancher2/issues/1209
Problem
Solution
An
extra_args_array
set field was added adjacent to the existingextra_args
field.Testing
Engineering Testing
Manual Testing
Here's a snippet demonstrating which fields were added, with everything else in ellipsis.
And these were the results, trimmed for clarity
Automated Testing
Tests have been added only to
rancher2/structure_cluster_rke_config_services_etcd_test.go
, since the tests for the other services would otherwise use identical schemas, flatteners, and expanders.QA Testing Considerations
Regressions Considerations