search

rancher / terraform-provider-rancher2

Terraform Rancher2 provider
https://www.terraform.io/docs/providers/rancher2/
Mozilla Public License 2.0
253 stars 218 forks source link

change default ubuntu image from DO #1213

Closed felipe-colussi closed 10 months ago

felipe-colussi commented 10 months ago

Issue: rancher/terraform-provider-rancher2#1215

Problem

Wile testing the migration of SDK to SDK2 I noticed that the default image for DO is no longer valid.

[tf-do-image.zip](https://github.com/rancher/terraform-provider-rancher2/files/12486407/tf-do-image.zip) Error creating machine: Error in driver during machine creation: POST https://api.digitalocean.com/v2/droplets: 422 You specified an invalid image for Droplet creation.

After checking DO only supports ubuntu 20 and 22.

Solution

Update the DO default image to: ubuntu-22-04-x64

Testing

Engineering Testing

Manual Testing

Using the terraform as it is: Tried to generate a UBUNTU RKE cluster using the default image. It fails. Change the image for ubuntu-22-04-x64 , it works.

After the change: I ran the tf with an empty image. It worked.

TF files: tf-do-image.zip

Automated Testing

I ran the automated tests. That said I didn't create one to test the "Default" value provided by TF SDK.

QA Testing Considerations

Regressions Considerations

felipe-colussi commented 10 months ago

@a-blender

@felipe-colussi Prov an RKE cluster on DO didn't give you any ssh/networking issues like you saw before? Not sure if the fix for this is a fix for what you were seeing a few days ago. Otherwise great catch!

Nop, that was happening on AWS, so I swapped to DO and got this image error :/