search

rancher / terraform-provider-rancher2

Terraform Rancher2 provider
https://www.terraform.io/docs/providers/rancher2/
Mozilla Public License 2.0
253 stars 218 forks source link

[Backport release/v3] Remove keypair_name from machine_config_v2 documentation #1226

Closed thatmidwesterncoder closed 9 months ago

thatmidwesterncoder commented 10 months ago

This is a backport for https://github.com/rancher/terraform-provider-rancher2/issues/1192

Original Issue below:

Other details Underlying Infrastructure: AWS Downstream clusters bootstrapped with Terraform

Issue description The keypair_name argument appears to not be supported in the context of Rancher provisioning EC2. Comparing with previous issues (1, 2, 3) and rancher/machine this argument in the documentation for the terraform provider can add confusion.

Expected behavior: Non implemented features should be removed from documentation

thatmidwesterncoder commented 10 months ago

QA Test Template

Root cause

Fields that existed in the terraform provider were not used by rancher, namely the keypair_name fields from the openstack and aws providers.

What was fixed, or what changes have occurred

The fields were removed from the terraform provider.

Areas or cases that should be tested

Terraform RC v4.0.0-rc2. Just sanity checking to make sure the provider still works. Since the fields weren't working before it shouldn't effect anything.

What areas could experience regressions?

N/A

Are the repro steps accurate/minimal?

No repro steps necessary.

For testing - use the v3.2.0-rc3 release.

thaneunsoo commented 9 months ago

Waiting for v4.0.0-rc2

zube[bot] commented 9 months ago

thaneunsoo said: Closing this issue based on this comment https://github.com/rancher/terraform-provider-rancher2/issues/1192#issuecomment-1737900287