search

rancher / terraform-provider-rancher2

Terraform Rancher2 provider
https://www.terraform.io/docs/providers/rancher2/
Mozilla Public License 2.0
253 stars 218 forks source link

add the support for graceful_shutdown_timeout for vSphere nodes #1228

Closed jiaqiluo closed 9 months ago

jiaqiluo commented 10 months ago

Issue:

https://github.com/rancher/terraform-provider-rancher2/issues/1222

Problem

We would like to have support for graceful_shutdown_timeout for vSphere nodes in the TF provider.

Solution

Add the support for graceful_shutdown_timeout for vSphere nodes

Testing

Engineering Testing

Manual Testing

This PR has been validated working in the internal vSphere envenomation, including RKE1/RKE2/K3s node-driver vsphere cluster

If the field graceful_shutdown_timeout is set in the vsphere_config, when we delete the cluster (terraform destory), the task "initial guest os shutdown" is triggered in vSphere Center Client, which does not happen if we do not set the flag.

Automated Testing

Exiting tests are expanded to cover the new field, and that is all we can do for now.

QA Testing Considerations

Provisioning and upgrading of the RKE1/RKE2/K3s node-driver vsphere cluster

Regressions Considerations

Provisioning and upgrading of the RKE1/RKE2/K3s node-driver vsphere cluster

felipe-colussi commented 9 months ago

Shouldn't u add a line under vsphere_config docs?

jiaqiluo commented 9 months ago

Shouldn't u add a line under vsphere_config docs?

@felipe-colussi, Good catch. PR is updated.