search

rancher / terraform-provider-rancher2

Terraform Rancher2 provider
https://www.terraform.io/docs/providers/rancher2/
Mozilla Public License 2.0
260 stars 223 forks source link

Updated RKE config machine pool schema and structure #1253

Closed gylli251 closed 9 months ago

gylli251 commented 11 months ago

Issue:

https://github.com/rancher/terraform-provider-rancher2/issues/1249

Problem

When you are creating an elemental cluster via terraform the apiversion which rancherv2 cluster uses by default for the machine_config is wrong. You need "elemental.cattle.io/v1beta1".

Solution

Added api_version as an option for machine_config via the schema and structure code. so we can do this:

image

Testing

I have no idea how to test properly not sure if its needed since these changes are very minor.

Engineering Testing

Manual Testing

Tested the provider myself and have created/destroyed/made changes in place, more than 10 clusters without fault.

Automated Testing

QA Testing Considerations

Regressions Considerations

My first real merge request on github, please advise me if you feel like i can do stuff better!

gylli251 commented 11 months ago

There seems to be something wrong with the build... not sure if its my fault or not.

a-blender commented 11 months ago

@gylli251 Nah, appears to be a flaky test. I restarted it.

kkaempf commented 10 months ago

ping @gylli251 👆🏻

gylli251 commented 10 months ago

I think i added documentation that is sufficient. please let me know if more is needed.