[BUG] rancher2_cluster shows changes on override_resource_requirements - Githubissues

rancher / terraform-provider-rancher2

Terraform Rancher2 provider

https://www.terraform.io/docs/providers/rancher2/

Mozilla Public License 2.0

253 stars 216 forks source link

[BUG] rancher2_cluster shows changes on override_resource_requirements #1318

Open zbialik opened 3 months ago

zbialik commented 3 months ago

Rancher Server Setup

Rancher version: v2.7.10
Installation option (Docker install/Helm Chart): Helm Chart
- If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): EKS v1.24
Proxy/Cert Details: n/a

Information about the Cluster

Kubernetes version: EKS v1.24
Cluster Type (Local/Downstream): Local
- If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider):
  When a memory limit is defined using Gi units, the terraform plan shows changes because it wants to convert it to Mi units even though they're equivalent. See below example:
```
!   resource "rancher2_cluster" "cluster-import" {
        id                         = "c-xxxxx"
        name                       = "cluster01"
        # (16 unchanged attributes hidden)

!       cluster_agent_deployment_customization {
!           override_resource_requirements {
!               memory_limit   = "1Gi" -> "1024Mi"
                # (3 unchanged attributes hidden)
            }

            # (1 unchanged block hidden)
        }

        # (1 unchanged block hidden)
    }
```
  To Reproduce
  1. Add a rancher2_cluster terraform resource with customized memory resource requirements using Gi units
  2. Run terraform apply to build the rancher2_cluster resource
  3. Re-run a terraform plan afterwards and observe the plan changes
  Actual Result
  
  See description
  
  Expected Result
  
  There should be no plan changes
  
  Screenshots
  
  Additional context