Add ExternalRules to RoleTemplate

rancher / terraform-provider-rancher2

Terraform Rancher2 provider

https://www.terraform.io/docs/providers/rancher2/

Mozilla Public License 2.0

253 stars 216 forks source link

Add ExternalRules to RoleTemplate #1356

Closed raulcabello closed 6 days ago

raulcabello commented 2 weeks ago

Problem

A new filed named ExternalRules is added to the RoleTemplate Custom Resource. Users need to be able to set this field from the terraform provider.

Solution

Add the ability to set ExternalRules in RoleTemplates using the Rancher terraform provider.

Testing

Engineering Testing

Manual Testing

Created a new RoleTemplate with ExternalRules
Add ExternalRules to an existing RoleTemplate

jiaqiluo commented 2 weeks ago

hi @raulcabello, similar to my comment on your other PR, could you rebase your PR against the base branch to pick up the updated GHA workflows?

raulcabello commented 2 weeks ago

The changes themselves look sane, I am not sure about the updates in the go mod, if we can get unit and acceptance tests working I think this change can be merged.

I bumped the Rancher version because we need the new RoleTemplate field. All those version bumps are because this new version of Rancher requires new versions of other dependencies.