search

rancher / terraform-provider-rancher2

Terraform Rancher2 provider
https://www.terraform.io/docs/providers/rancher2/
Mozilla Public License 2.0
263 stars 228 forks source link

Add pull request workflow #1359

Closed HarrisonWAffel closed 5 months ago

HarrisonWAffel commented 5 months ago

Problem

1351 missed a workflow for pull requests, as such we are not building and packaging the provider before allowing PRs to be merged

Solution

Add a pull request workflow which builds and packages the provider for each PR. This PR does not include the acceptance tests, as additional effort needs to be put into how we can modernize those tests such that they can work against a more modern version of rancher.

Testing

I've tested this workflow on my personal fork

Actions run: https://github.com/HarrisonWAffel/terraform-provider-rancher2/actions/runs/9571691853/job/26389359180

HarrisonWAffel commented 5 months ago

I've updated to ubuntu-latest, and removed make package-rancher. Initial thought process was to more closely mirror what release CI does, but if this step was not being done while running in drone I agree we should drop it.