default dynamic to false - Githubissues

rancher / terraform-provider-rancher2

Terraform Rancher2 provider

https://www.terraform.io/docs/providers/rancher2/

Mozilla Public License 2.0

263 stars 228 forks source link

default dynamic to false #1427

Closed kinarashah closed 2 weeks ago

kinarashah commented 1 month ago

Issue:

https://github.com/rancher/terraform-provider-rancher2/issues/1426

Solution

I removed default truefor the dynamic field to align with the default API settings, which also has the added benefit of resolving the issue of duplicate entries being added.

Manual Testing

Set up an RKE2 cluster following the steps in the linked issue. Ran multiple updates on the cluster to confirm that no duplicate entries were added.
Changed the default PSACT from rancher-restricted to rancher-privileged and made sure it worked without causing the cluster to error out with the message secret xxxx-psact does not contain the expected content.

matttrach commented 2 weeks ago

looks like this needs to be backported to v5 to target Rancher v1.9

matttrach commented 2 weeks ago

@kinarashah please sign your commits and this is good to merge.