search

rancher / terraform-provider-rancher2

Terraform Rancher2 provider
https://www.terraform.io/docs/providers/rancher2/
Mozilla Public License 2.0
261 stars 226 forks source link

AKS defaults to AvailabilitySet #457

Closed ams0 closed 4 years ago

ams0 commented 4 years ago

AKS clusters default to AvailabilitySet instead of the more modern VirtualMachineScaleSets. I can see that the request sent to Azure doesn't even contain the appropriate key

sanitized request body: {"location":"West Europe","tags":{"displayName":"aks"},"properties":{"kubernetesVersion":"1.17.9","dnsPrefix":"aksrancher","agentPoolProfiles":[{"name":"rancher","count":2,"vmSize":"Standard_B4ms","osDiskSizeGB":30,"storageProfile":"ManagedDisks","vnetSubnetID":"/subscriptions/12c7e9d6-967e-40c8-8b3e-4659a4ada3ef/resourceGroups/rancheraks/providers/Microsoft.Network/virtualNetworks/ranchervnet/subnets/ranchersubet","maxPods":110,"osType":"Linux"}],"linuxProfile":{"adminUsername":"rancher","ssh":{"publicKeys":[{"keyData":"ssh-rsa AAAAB3Nza"}]}},"servicePrincipalProfile":{"clientId":"cca39846-4dd8-4a83-a575-753451183da9","secret":"REDACTED"},"addonProfiles":{"httpApplicationRouting":{"enabled":false,"config":null},"omsagent":{"enabled":false,"config":null}},"enableRBAC":true,"networkProfile":{"networkPlugin":"kubenet","podCidr":"172.244.0.0/16","serviceCidr":"10.0.0.0/16","dnsServiceIP":"10.0.0.10","dockerBridgeCidr":"172.17.0.1/16"}}}

There should be a type for the AgentPoolType (https://docs.microsoft.com/en-us/rest/api/aks/agentpools/createorupdate#agentpooltype) property in the agentpool profile.

rawmind0 commented 4 years ago

The provider is not doing Azure request, it's done by rancher. Have you tested this config using Rancher UI?? Is working on it?? I'm guessing that the issue should be opened on Rancher

ams0 commented 4 years ago

Ah! Makes sense now, afaict, rancher still doesn’t do VMSS. Thanks, I’m wrapping my head around rancher+AKS, lots to learn still.

—- Live long and prosper

From: Raúl Sánchez notifications@github.com Sent: Tuesday, September 15, 2020 8:42:43 PM To: rancher/terraform-provider-rancher2 terraform-provider-rancher2@noreply.github.com Cc: Alessandro Vozza Alessandro.Vozza@microsoft.com; Author author@noreply.github.com Subject: Re: [rancher/terraform-provider-rancher2] AKS defaults to AvailabilitySet (#457)

The provider is not doing Azure request, it's done by rancher. Have you tested this config using Rancher UI?? Is working on it?? I'm guessing that the issue should be opened on Rancherhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Francher%2Francher&data=02%7C01%7Calessandro.vozza%40microsoft.com%7C93c81aa115184d65db4508d859a721fa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637357921785436281&sdata=xquLTx7yN0md5cT1NFFR79o1UvR%2FguQaRQjzcno%2FkhM%3D&reserved=0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Francher%2Fterraform-provider-rancher2%2Fissues%2F457%23issuecomment-692902055&data=02%7C01%7Calessandro.vozza%40microsoft.com%7C93c81aa115184d65db4508d859a721fa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637357921785446275&sdata=TF5XjdCHi0uMdKkzqEKkUySTE1767eNAMSAe8GIHQqY%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAALYJ2F2H65FJ62R2D7EIGDSF6YSHANCNFSM4RNRNQUQ&data=02%7C01%7Calessandro.vozza%40microsoft.com%7C93c81aa115184d65db4508d859a721fa%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637357921785446275&sdata=GI98UW7y64suhg0jcjyz%2FH1J2jiesuuNWxdtK1cJ1q0%3D&reserved=0.

rawmind0 commented 4 years ago

Please, reopen issue if needed.