RKE2 docker provider doesn't accept RKE2 version with two digits in patch version part so cannot install v1.28.10+rke2r1

thehejik commented 3 months ago

What steps did you take and what happened?

Found on rancher:v2.8-head with rancher-turtles:0.8.0 operator and capi:0.5.0 UI extension.

I was trying to bump RKE2 versions at https://github.com/rancher-sandbox/rancher-turtles-fleet-example/blob/docker-rke2/clusters/cluster1.yaml#L70 to v1.28.10+rke2r1 together with kindest bump to 1.28 and after attempt to deploy RKE2 docker cluster by fleet it failed on: pasted_image

Seems the two digits numer in patch level 10 is not accepted by the used regexp.

I used this docker-rke2 provider:

apiVersion: turtles-capi.cattle.io/v1alpha1
kind: CAPIProvider
metadata:
  name: docker-rke2
  namespace: capd-system
spec:
  name: docker-rke2
  type: infrastructure
  configSecret:
    name: variables
  fetchConfig:
    url: https://github.com/belgaied2/cluster-api/releases/v1.3.3-cabpr-fix/infrastructure-components.yaml
  version: v1.3.3-cabpr-fix

What did you expect to happen?

The cluster will be provisioned regardless of RKE2 version used.

How to reproduce it?

No response

Rancher Turtles version

No response

Anything else you would like to add?

I was able to bump RKE2 to v1.29.5+rke2r1.

Label(s) to be applied

/kind bug

furkatgofurov7 commented 3 months ago

@thehejik may I ask why not to use the official release of CAPRKE2 instead of forked release and confirm if you face the same issue?

thehejik commented 3 months ago

@furkatgofurov7 sorry what component do you mean? The error comes from RKE2 control-plane provider which is preinstalled by turtles/CAPI.

rancher / turtles