Providers version not being updated with turtles upgrade

cpinjani commented 2 months ago

What steps did you take and what happened?

Steps:

Install turtles v0.10.0 and enable docker, aws, gcp infra providers using capi-ui extension
Following versions are installed: docker: v1.4.6, aws: v2.3.5, gcp: v1.6.0 (auto-installed with turtles - core: v1.4.6, rke2: v0.4.1, addon: v0.3.1)

Upgrade turtles to v0.11.0 and check provider versions, core and rke2 versions are upgraded along with turtles version upgrade and not other providers (core: v1.7.3, rke2: v0.5.0)

What did you expect to happen?

Installed CAPI Providers should upgrade if newer version is available, along with turtles upgrade

How to reproduce it?

Steps mentioned above.

Rancher Turtles version

v0.11.0

Danil-Grigorev commented 1 month ago

This should be implemented as a part of #742

Danil-Grigorev commented 1 month ago

Actually, became a part of #751

cpinjani commented 1 month ago

Non-custom providers are auto-upgraded with turtles upgrade - v0.10 -> v0.11 -> v0.12

Logs:

I0927 06:41:39.686606       1 provider_sync.go:195] "Version latest is beyond current latest, updated to v0.7.0" controller="capiprovider" controllerGroup="turtles-capi.cattle.io" controllerKind="CAPIProvider" CAPIProvider="rke2-bootstrap-system/rke2-bootstrap" namespace="rke2-bootstrap-system" name="rke2-bootstrap" reconcileID="c7cf3454-70cc-4a45-9911-ef7aca34c3e1"
I0927 06:41:39.706151       1 provider_sync.go:195] "Version latest is beyond current latest, updated to v2.6.1" controller="capiprovider" controllerGroup="turtles-capi.cattle.io" controllerKind="CAPIProvider" CAPIProvider="capa-system/aws" namespace="capa-system" name="aws" reconcileID="0b5f800e-36e5-4564-9197-d9a8428b80fa"
I0927 06:41:39.736128       1 provider_sync.go:195] "Version latest is beyond current latest, updated to v1.7.3" controller="capiprovider" controllerGroup="turtles-capi.cattle.io" controllerKind="CAPIProvider" CAPIProvider="capd-system/docker" namespace="capd-system" name="docker" reconcileID="1bee8465-f8b1-49cc-89df-e906ae799c73"
I0927 06:41:40.173234       1 provider_sync.go:195] "Version latest is beyond current latest, updated to v1.7.3" controller="capiprovider" controllerGroup="turtles-capi.cattle.io" controllerKind="CAPIProvider" CAPIProvider="capi-system/cluster-api" namespace="capi-system" name="cluster-api" reconcileID="bd1193f5-7f97-40b7-b228-54f9e848f124"
I0927 06:41:40.191199       1 provider_sync.go:195] "Version latest is beyond current latest, updated to v0.7.0" controller="capiprovider" controllerGroup="turtles-capi.cattle.io" controllerKind="CAPIProvider" CAPIProvider="rke2-control-plane-system/rke2-control-plane" namespace="rke2-control-plane-system" name="rke2-control-plane" reconcileID="ef1e470c-b0d7-41df-b87e-64ee40220daf"
I0927 06:41:40.224407       1 provider_sync.go:195] "Version latest is beyond current latest, updated to v0.3.1" controller="capiprovider" controllerGroup="turtles-capi.cattle.io" controllerKind="CAPIProvider" CAPIProvider="rancher-turtles-system/fleet" namespace="rancher-turtles-system" name="fleet" reconcileID="41c05302-7dd1-4853-ba14-fcb09ae55785

furkatgofurov7 commented 1 month ago

why kubeadm cp/bootstrap versions are not auto-updated to v1.7.3?

Danil-Grigorev commented 1 month ago

@furkatgofurov7 What you don’t see here is that the version for one Kubeadm provider is pinned to v1.4.6, while the other is unset. The provider with a pinned version has a condition set, and it falls into category of user managed providers (version is managed by user).

If the provider does not have version set, it is automatically updated, which is visible from the screen.

  - lastTransitionTime: "2024-09-27T09:15:54Z"
    message: Provider version update available. Current latest is v1.7.3
    reason: UpdateAvailable
    severity: Info
    status: "False"
    type: CheckLatestVersionTime

furkatgofurov7 commented 1 month ago

@Danil-Grigorev I don't see where it is visible that they are pinned, but overall I got the idea, thanks!

cpinjani commented 1 month ago

Filed bug to track above issue https://github.com/rancher/turtles/issues/758

rancher / turtles