search

rancher / windows

Rancher Windows Team project repository.
Apache License 2.0
11 stars 6 forks source link

cloudbase-init does not handle underscores in user-data.iso file names (meta-data and user-data) #155

Closed rosskirkpat closed 1 year ago

rosskirkpat commented 2 years ago

This issue is for tracking the upstream cloudbase-init issue: https://github.com/cloudbase/cloudbase-init/issues/89

We have fixed this in rancher/machine https://github.com/rancher/machine/pull/168 and will keep this issue open until it's fixed upstream.

We are working with cloudbase-init upstream to addresses the naming issue we have found.

luthermonson commented 2 years ago

more details on the issue, in rancher/machine we added cloud-init nocloud to vsphere to boot nodes: https://github.com/rancher/machine/blob/master/drivers/vmwarevsphere/cloudinit.go#L198-L201

ISO9660 only supports A-Z0-9_ and converts user-data to USER_DATA which is accounted for in cloud-init but we have found out that cloudbase-init does not do any conversions to find different file name on the ISO.

We want to do two things 1) add joliet extension support to go-diskfs, they want it any way it's part of their public plans. we then add that extension to machine. this will let out of the box cloudbase-init function again with our implementation. @luthermonson is looking at this and using inspiration from genisoimage 2) add cloudbase-init functionality to grab the USER_DATA file and function more like upstream cloud-init basically making it more fool proof if someone else tries to use a non-joliet extended ISO, @rosskirkpat is looking into that and using inspiration from upstream cloud-init

rosskirkpat commented 2 years ago

We have fixed this issue in rancher/machine https://github.com/rancher/machine/pull/168