search

rancherfederal / rancher-cluster-templates

Helm Chart for Provisioning Clusters with the Rancher Multi-Cluster Manager with Rancher Cluster Templates
MIT License
0 stars 5 forks source link

[RFE] Make Network Configuration an Array #12

Open shabazzfsher opened 4 months ago

shabazzfsher commented 4 months ago

Feature Request

Request description: Customer requests that Network configuration be structured as an array.

Example:

apiVersion: rke-machine-config.cattle.io/v1
kind: VmwarevsphereConfig
metadata:
  name: nc-vsphere-master-config
  namespace: fleet-default
network:
- /Example/VM-Network
os: linux
cfgparam:
- disk.enableUUID=TRUE
bcdurden commented 3 months ago

This is already supported, and I think it is the nodevalues file that is misleading.

Values:

  # vSphere networks where the virtual machine will be attached
  network: 
  - "/Datacenter/network/rgs-network"

Template:

network: {{ $nodepool.network }}

Result fed to K8S API:

network: 
- "/Datacenter/network/rgs-network"
bcdurden commented 3 months ago

I will add a nodevalues file for vsphere and detail this better.

zlmitchell commented 2 months ago

@bcdurden Yes the API is an array, the helmchart only allows a single value. The helmchart needs to be updated to allow an array in the values.yaml and be received in the following file

https://github.com/rancherfederal/rancher-cluster-templates/blob/main/charts/cluster-templates/templates/nodeconfig-vsphere.yaml#L83

zackbradys commented 4 weeks ago

VMWare vSphere is still pending validation with rancher-cluster-templates. Please be patient as we try to test, validate, and support additional cloud providers.

https://github.com/rancherfederal/rancher-cluster-templates/tree/main/charts/cluster-templates#supported-providers