rancherfederal / rancher-cluster-templates

Helm Chart for Provisioning Clusters with the Rancher Multi-Cluster Manager with Rancher Cluster Templates

Apache License 2.0

7 stars 9 forks source link

[RFE] Tag should be an array? #14

Closed shabazzfsher closed 6 months ago

shabazzfsher commented 7 months ago

Feature Request

Request description: Customer requests that tag field should be an array? (Not 100% on this one but would make sense, need to check the spec of vmwarevsphereconfig to be sure)

bcdurden commented 6 months ago

The tag field is an array. The helm chart does not enforce this but the Rancher CRD does.

>kubectl explain VmwarevsphereConfig.tag
GROUP:      rke-machine-config.cattle.io
KIND:       VmwarevsphereConfig
VERSION:    v1

FIELD: tag <[]string>

DESCRIPTION:
    vSphere tag id e.g. urn:xxx

zlmitchell commented 5 months ago

@bcdurden Did you check the helmchart before closing this. You're killing me Brian. Yes the API is an array, the helmchart only allows a single value. The helmchart needs to be updated to allow an array in the values.yaml and be received in the following file

https://github.com/rancherfederal/rancher-cluster-templates/blob/main/charts/cluster-templates/templates/nodeconfig-vsphere.yaml#L40

zlmitchell commented 5 months ago

@zackbradys can you reopen this.