shabazzfsher commented 4 months ago

Feature Request

Request description: User cannot configure any of the ETCD section. So setting Cron Schedule or S3 configuration are both unavailable.

https://github.com/rancherfederal/rancher-cluster-templates/blob/main/charts/cluster-templates/templates/cluster.yaml#L81

Example: Here is an example of what it should look like.

  etcd:
    {{- if .Values.etcd.s3.endpoint }}
      s3:
        bucket: {{ .Values.etcd.s3.bucket }}
        {{- if .Values.etcd.s3.cloudCredentialName }}
        cloudCredentialName: "{{ .Values.etcd.s3.cloudCredentialName }}"
        {{- end }}
        endpoint: {{ .Values.etcd.s3.endpoint }}
        {{- if .Values.etcd.s3.endpointCA }}
        endpointCA: {{ .Values.etcd.s3.endpointCA }}
        {{- end }}
        {{- if .Values.etcd.s3.folder }}
        folder: {{ .Values.etcd.s3.folder }}
        {{- end }}
        region: {{ .Values.etcd.s3.region }}
    {{- end }}
      snapshotRetention: {{ .Values.etcd.snapshotRetention }}
      snapshotScheduleCron: {{ .Values.etcd.snapshotScheduleCron }}

bcdurden commented 3 months ago

The Rancher CRD supports these fields, they appear to just not be enabled yet in the helmchart.

>kubectl explain cluster.spec.rkeConfig
GROUP:      provisioning.cattle.io
KIND:       Cluster
VERSION:    v1

FIELD: rkeConfig <Object>

DESCRIPTION:
    <empty>
FIELDS:
  additionalManifest    <string>
    <no description>

  chartValues   <Object>
    <no description>

  etcd  <Object>
    <no description>

  etcdSnapshotCreate    <Object>
    <no description>

  etcdSnapshotRestore   <Object>
    <no description>
...

zackbradys commented 4 weeks ago

We are working on this feature and functionality in the next release of rancher-cluster-templates. Thank you for your patience on getting this supported in the chart.

rancherfederal / rancher-cluster-templates

[RFE]: set etcd snapshotRetention/cron #16

Feature Request