rancherfederal / rancher-cluster-templates

Helm Chart for Provisioning Clusters with the Rancher Multi-Cluster Manager with Rancher Cluster Templates
MIT License
0 stars 5 forks source link

Add Multus DHCP DaemonSet creation logic #25

Open Woovie opened 1 week ago

Woovie commented 1 week ago

Problem

Presently if you want to enable Multus' DHCP DaemonSet features using our cluster templates, it will not correctly include them. This goes really for almost anything that would end up under the chartValues section of a Cluster template.

Proposed Solution

Similar to other sections of the configuration, it would be worthwhile to iteratively process the chartValues section and include those, although I can see that logic being very tricky with particularly cloudprovider options.

Example workaround code

I wrote a very basic solution to test a slight restructure of this section: https://github.com/Woovie/rancher-cluster-templates/commit/9ba217c8befc73eacbb05c17ae2e3fe63faf7c92

I do think that moving the chartValues key outside of the if blocks here would be a good change, but a lot of work needs to be done to do this right.