Closed robnk23 closed 1 year ago
CC: @zackbradys @clemenko
I saw in previous PRs that the tests may not be working correctly? @mddamato @dgvigil?
We fixed them. The tests should be working now. We'll take a look.
fixed the tests in #176, once that's merged we can re-test and merge
~@robnk23 could you rebase onto the new main?~ Never mind, I rebased for you
What type of PR is this?
What this PR does / why we need it:
During a tarball install the rke2 executable will be run from a temporary directory created in the system default temp directroy (usually
/tmp
), which means the install will fail when/tmp
is mounted with thenoexec
option.This PR parameterizes the path to the parent directory of the temporary directory that gets created by adding the
tarball_temp_dir
variable, while leaving it to the system default iftarball_temp_dir
is not specified.Which issue(s) this PR fixes:
Fixes #172
Special notes for your reviewer:
N/A
Testing
Tested performing tarball installs with
tarball_temp_dir
undefined and defined to point to a path other than the system default temp dir.Release Notes
Parameterized tmp dir used during a tarball install.