search

rancherfederal / rke2-aws-tf

MIT License
82 stars 69 forks source link

feat: add variable for setting the cpu_credits parameter in launch template #35

Open AbrohamLincoln opened 3 years ago

AbrohamLincoln commented 3 years ago

also updates existing README files

aleiner commented 1 year ago

Thanks for the contribution. We've looked though some documentation and have concerns about specifying a default value as the aws-set default value varies as it's based on instance type - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#credit-specification

We don't want to change the default value of a T3 instance, for example, without the user intentionally specifying that change.