rancherfederal / rke2-aws-tf

MIT License
84 stars 68 forks source link

fix: add aws_s3_bucket_ownership_controls resource for statestore module so ACL can be created. #80

Closed rexwangcc closed 1 year ago

rexwangcc commented 1 year ago

Turns out AWS has changed their default ACL behavior of S3 buckets since 2023/04: https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/

This PR adds aws_s3_bucket_ownership_controls to statestore module to mimic the default behavior before 2023.04 of AWS S3.

rexwangcc commented 1 year ago

Any review resource I can get on this? Internally at our org we have accommodated the change into our fork but keep this PR on pending will affect other folks in the community who are relying on this module, I'm afraid. Thanks!

@adamacosta

jhdev1 commented 1 year ago

Thank you