search

rancherlabs / support-tools

Apache License 2.0
142 stars 88 forks source link

Profile collector #263

Closed rbreddy closed 4 months ago

rbreddy commented 5 months ago

Establishing a new script to collect Rancher golang profiles (https://pkg.go.dev/runtime/pprof)

rbreddy commented 5 months ago

Could you please add a README.md file explaining the purpose of the script, an example of its usage, and details on any arguments?

I see several parameters, such as APP at the top of the script, if the user is expected to set these it would be better if this could be passed as an argument to the script. For and example of how this is done in the log collector see https://github.com/rancherlabs/support-tools/blob/master/collection/rancher/v2.x/logs-collector/rancher2_logs_collector.sh#L1038

Hello @axeal, added the README and passing as parameters for most of arguments (for now aks blobs will be kept to be hardcoded)

Tejeev commented 5 months ago

@axeal How's this looking to you? Are we good to merge now?

moio commented 5 months ago

Please, can this be merged? I came across multiple cases that need this in the last month since the PR was first opened, and would love to give customers and colleagues an official link.

Any things can always be improved later by follow-up PRs if needed.

Thanks in advance