rancilio-pid / clevercoffee

Do-It-Yourself PID für Espressomaschinen
https://clevercoffee.de
GNU General Public License v2.0
287 stars 144 forks source link

Pid Values out of range #270

Closed cottec closed 2 years ago

cottec commented 2 years ago

Quickmill uses a cold start Kp of 250 which is out of defined parameter range

Alcoinus commented 2 years ago

The issue should be the following line:

https://github.com/rancilio-pid/ranciliopid/blob/9bb3816a4f0c485dc99e01975b2b5ae1dbef0629/src/rancilio-pid.h#L38

As I am in no position to propose a new general value for this parameter, I am not opening a pull request. But you can change it locally to whatever suits you (>=250 I guess).

kjyv commented 2 years ago

If 250 is indeed the proper value for some machines, sure the maximum can be higher - I've set it a bit arbitrarily I have to admin. Please add a PR with a max value that seems reasonable also for quickmill machines

cottec commented 2 years ago

272

murmeltier08 commented 2 years ago

solved