search

rancilio-pid / clevercoffee

Do-It-Yourself PID für Espressomaschinen
https://clevercoffee.de
GNU General Public License v2.0
277 stars 144 forks source link

Animated WaterEmpty Logo (configurable) #456

Closed genkigenki closed 6 months ago

genkigenki commented 7 months ago

Changed code so WaterEmpty-animation is configurable. Rebase & code cleanup. New configuration option can be used for other animations, e.g. brew-logo-animation.

fiendie commented 7 months ago

To be perfectly honest, animations are a can of worms I don't really want to open. This is a lot of code for a little visual gimmick.

genkigenki commented 7 months ago

To be perfectly honest, animations are a can of worms I don't really want to open. This is a lot of code for a little visual gimmick.

The base code (displayAnimCounter, FEATURE_ANIMATIONS) is needed only once (about 50%). Follow-up animations are less code. LoQue has shown interest. @LoQue90 ? By the way, feature is off by default.

fiendie commented 7 months ago

It's a feature with very little real-world benefit. The way it's implemented doesn't really match what we're trying to achieve with version 4.0+. We want to focus on stability and features that actually move the project forward. This would have to be ported, tested and maintained through all the necessary changes to the underlying architecture of how we handle feature sets and it's just not worth the effort in my opinion.

LoQue90 commented 7 months ago

Yes I like it, but I will add this locally to my mashine.

fiendie commented 6 months ago

Ok, closing it then.

genkigenki commented 6 months ago

Hi, can you reconsider? The comments in Discord were positive, thats why i rebased the code since December... Porting effort is on me - hope you see that I am an active contributor.