rancilio-pid / clevercoffee

Do-It-Yourself PID für Espressomaschinen
https://clevercoffee.de
GNU General Public License v2.0
277 stars 144 forks source link

Fixed the scale readout with timed brewmode selected #484

Closed jsve-dev closed 4 months ago

jsve-dev commented 6 months ago

Fixed shottimerscale(); never getting called with appropriate settings enabled.

Ps. this is my first pull request. I have about -18 idea what im doing... Hope im helping 😀

LoQue90 commented 6 months ago

I'm very sorry, but this pr is doing a lot of stuff, but nothing that will actually change something helpful. What do you want to achieve?

LoQue90 commented 6 months ago

Okay if I look only at the total diff, it's okay. But it should only be one commit. This shottimer scale call should only be done for people which are using only the pid and the scale. If you are using the scale and controlling the brew, the scale shottimer is called differently.

fiendie commented 6 months ago

Okay if I look only at the total diff, it's okay. But it should only be one commit. This shottimer scale call should only be done for people which are using only the pid and the scale. If you are using the scale and controlling the brew, the scale shottimer is called differently.

I've been chatting with him about this yesterday. I'll help squash the commits :)

jsve-dev commented 6 months ago

Cleaned up the mess... Now it just the useful change. Thanks @fiendie

LoQue90 commented 6 months ago

Can you tell my why do you want that change? What is your setup?

jsve-dev commented 6 months ago

In the case of full expansion with valve control and scale. But still brew by time with continuous readout of scale output. Without calling shottimerscale() the scale turns off during a brew and the readout shows 0.0g.

I of course had not thought about the pid-only usecase, but changing the line to BREWCONTROL_TYPE <= 1 should cover both instances

LoQue90 commented 6 months ago

Should be < 2 to not make weird stuff if someone uses brew by scale.

jsve-dev commented 6 months ago

Changed to <2

FabianSperrle commented 4 months ago

I think that's no longer needed with the current master? I see the weight in the shot timer -- or did I misunderstand this PR?

LoQue90 commented 4 months ago

@FabianSperrle but you also have brewcontrol 2 set? This one should fix the scale readout for onlypidscale. If I'm correct.

FabianSperrle commented 4 months ago

Whoops, thanks for the hint!