Closed jsve-dev closed 4 months ago
I'm very sorry, but this pr is doing a lot of stuff, but nothing that will actually change something helpful. What do you want to achieve?
Okay if I look only at the total diff, it's okay. But it should only be one commit. This shottimer scale call should only be done for people which are using only the pid and the scale. If you are using the scale and controlling the brew, the scale shottimer is called differently.
Okay if I look only at the total diff, it's okay. But it should only be one commit. This shottimer scale call should only be done for people which are using only the pid and the scale. If you are using the scale and controlling the brew, the scale shottimer is called differently.
I've been chatting with him about this yesterday. I'll help squash the commits :)
Cleaned up the mess... Now it just the useful change. Thanks @fiendie
Can you tell my why do you want that change? What is your setup?
In the case of full expansion with valve control and scale. But still brew by time with continuous readout of scale output. Without calling shottimerscale() the scale turns off during a brew and the readout shows 0.0g.
I of course had not thought about the pid-only usecase, but changing the line to BREWCONTROL_TYPE <= 1 should cover both instances
Should be < 2 to not make weird stuff if someone uses brew by scale.
Changed to <2
I think that's no longer needed with the current master? I see the weight in the shot timer -- or did I misunderstand this PR?
@FabianSperrle but you also have brewcontrol 2 set? This one should fix the scale readout for onlypidscale. If I'm correct.
Whoops, thanks for the hint!
Fixed shottimerscale(); never getting called with appropriate settings enabled.
Ps. this is my first pull request. I have about -18 idea what im doing... Hope im helping 😀