search

rancilio-pid / clevercoffee

Do-It-Yourself PID für Espressomaschinen
https://clevercoffee.de
GNU General Public License v2.0
277 stars 144 forks source link

Draft: Drop ColdStart and AtSetPoint States #486

Closed simonspa closed 5 months ago

simonspa commented 6 months ago

This PR drops the ColdStart state. The only difference with respect to PidNormal was that it made use of PonM in case it was activated. PidNormal always ignored this setting.

This PR moves PonM to the PidNormal state.

The AtSetPoint state was only entered from the ColdStart state and did not serve any purpose, hence it is also removed.

Without the ColdStart state, the condition for displaying the heating logo had to be changed. It is now displayed whenever in the PidNormal state and when the temperature is at least 5degC below the setpoint.

simonspa commented 5 months ago

Current master, no PonM in PidNormal state:

image

Current this branch, PonM active in PidNormal state (default start values):

image

fiendie commented 5 months ago

I always thought the idea of a separate cold start phase was a bit overrated because the group needs time to heat up.