search

rand00 / conntest

MirageOS unikernel to test networking
GNU Lesser General Public License v2.1
16 stars 7 forks source link

Implement ring map #9

Closed waringa-mercy closed 1 year ago

waringa-mercy commented 1 year ago

@rand00 i have made some progress but still experiencing some errors. monday being the deadline for submission and application kindly guide me on how to solve the errors. i have included comments on what each each part is supposed to do

rand00 commented 1 year ago

I guess it is issue #2 you are trying to solve?

The code expected would be the definition of Ring.map_rev_shortcircuit, which is not what this PR proposes.

As I wrote on the issue, it would be useful to have a look at the existing Ring.fold_left, which I expect is okay close to what is needed for map_rev_shortcircuit

waringa-mercy commented 1 year ago

@rand00 i have made a few changes. Due to the limited time i have, kindly bear with the very many follow up questions i will ask

waringa-mercy commented 1 year ago

@rand00 I took the time to study the pointers you gave and came up with a potential solution. kindly review and advice Asap. to day being the deadline for application, I would kindly request to to fill out as accepted and if there are any changes, i will keep working till acceptable.

waringa-mercy commented 1 year ago

@rand00 kindly ignore my previous commit with the message progress with errors. i tried deleting it without much success. my latest commit compiles successfully

rand00 commented 1 year ago

If you intend to continue work on this, then please don't close the PR and start a new one - continue on this PR

waringa-mercy commented 1 year ago

@rand00 sorry, already did. should i continue on this one or the other one? i felt like my latest changes were being lost in the middle or the erroneous code i commited three days ago when i was stuck and needed some guidance.

waringa-mercy commented 1 year ago

@rand00 can we please proceed in my latest pull request? i have made a few changes already plus i already deleted locally.

waringa-mercy commented 1 year ago

@rand00 I have attempted to restore the branch i deleted without success since i deleted both locally and remotely. I do not know how to proceed.

rand00 commented 1 year ago

In that case continue with the new PR

waringa-mercy commented 1 year ago

@rand00 Thank you. Honestly i was feeling really demoralized. On friday i was so worried about the deadline that I was trying anything that was even remotely close to what was expected just to submit.Then the weekend came and i knew you would not be available to help. The moment i calmed down and had a deeper look at the code itself, it all became so clear. I already pushed new changes. Review them and let me know if anything more needs to be added. The deadline up now, so now is a learning phase

rand00 commented 1 year ago

Sounds like you had good mental progress on it (:

waringa-mercy commented 1 year ago

@rand00 I did. I went back to the first code i posted where you told me i was a good try. Looked at the recommendations and that helped a lot. This is a learning period, even if i dont get picked for the internship, no regrets. In the end, i have to struggle till I get it right. AI might be useful in essays and what not but when it comes to writing code, a complete joke.

waringa-mercy commented 1 year ago

@rand00 if there are any other good issues, I would love to keep contributing. Without the burden of looming deadline, I will revel in the challenge